Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert request.body into Readable in node:http #16355

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

This makes node:http go through the node:stream code path instead of the ReadableStream code path for request bodies

Need to check the memory & http req/s impact of this change before it merges

How did you verify your code works?

@robobun
Copy link

robobun commented Jan 12, 2025

Updated 9:52 AM PT - Jan 12th, 2025

@Jarred-Sumner, your commit a6b7f49 has passed in #9480! 🎉


🧪   try this PR locally:

bunx bun-pr 16355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants