Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript emitDecoratorMetadata for getters #16389

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pfgithub
Copy link
Contributor

What does this PR do?

Fixes #14863

@robobun
Copy link

robobun commented Jan 14, 2025

Updated 8:04 PM PT - Jan 16th, 2025

@pfgithub, your commit 3603cc8 has 1 failures in #9864:

  • test/integration/next-pages/test/next-build.test.ts - annotation error on 🍎 14 aarch64

🧪   try this PR locally:

bunx bun-pr 16389

@pfgithub pfgithub changed the title Pfg/fix reflect metadata Fix typescript emitDecoratorMetadata for getters Jan 14, 2025
@shiz-ceo
Copy link

Is this related with #9838?

@pfgithub
Copy link
Contributor Author

pfgithub commented Jan 16, 2025

@shiz-ceo That issue is likely not fixed, but I'm not sure how to reproduce it so I can't check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflect Metadata - design:returntype is wrong for getter properties
3 participants