Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass more node tests in util and readline #16425

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Pass more node tests in util and readline #16425

wants to merge 17 commits into from
+2,094 −772

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Jan 16, 2025 •
edited
Loading

TODO:

  • readline.node.test.ts

@robobun
Copy link

robobun commented Jan 16, 2025 •
edited
Loading

Updated 2:41 PM PT - Jan 17th, 2025

✅ @pfgithub, your commit 721d1ce has passed in #9944! 🎉

🧪   try this PR locally:

bunx bun-pr 16425

@pfgithub pfgithub marked this pull request as ready for review January 16, 2025 04:06
@pfgithub pfgithub marked this pull request as draft January 17, 2025 02:47
@pfgithub pfgithub marked this pull request as ready for review January 18, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfgithub @robobun @Jarred-Sumner