Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[install] sanitise against malformed bun.lockb #2397

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

alexlamsl
Copy link
Contributor

fixes #2392

@Jarred-Sumner
Copy link
Collaborator

The unique packages bitset was useful for checking if the same package already exists

I’m confused why it’s unnecessary

@alexlamsl
Copy link
Contributor Author

AFAICT unique_packages has not been in use since the deduplication code got commented out − historically, it was used to populate duplicate_resolutions_bitset which in turn was not being read anywhere else either 🤔

@Jarred-Sumner Jarred-Sumner merged commit acd3618 into oven-sh:main Mar 15, 2023
@Jarred-Sumner
Copy link
Collaborator

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hanging issue with bun install
2 participants