Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] skip private class fields in expect.toEqual #3484

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

dylan-conway
Copy link
Member

No description provided.

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lets merge once tests run

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

@dylan-conway 5 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#bedd6ed0ee263b8570ed25b5327545cb3990a758

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

@dylan-conway 5 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#bedd6ed0ee263b8570ed25b5327545cb3990a758

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

@dylan-conway 8 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#bedd6ed0ee263b8570ed25b5327545cb3990a758

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

@dylan-conway 9 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#bedd6ed0ee263b8570ed25b5327545cb3990a758

@Jarred-Sumner Jarred-Sumner merged commit c033d55 into main Jul 1, 2023
@Jarred-Sumner Jarred-Sumner deleted the dylan/toEqual-skip-private-class-fields branch July 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants