Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leak in fd #3487

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Fix leak in fd #3487

merged 3 commits into from
Jul 2, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023 •
edited
Loading

❌ @Jarred-Sumner 7 files with test failures on bun-darwin-aarch64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#750b1a5482fc7cc15a61d15a1c5ff6a1176318d9

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023 •
edited
Loading

❌ @Jarred-Sumner 5 files with test failures on linux-x64:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#750b1a5482fc7cc15a61d15a1c5ff6a1176318d9

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023 •
edited
Loading

❌ @Jarred-Sumner 5 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/node/watch/fs.watch.test.js
  • test/js/web/fetch/fetch-leak.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#750b1a5482fc7cc15a61d15a1c5ff6a1176318d9

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023 •
edited
Loading

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

  • test/cli/install/bun-run.test.ts
  • test/cli/test/bun-test.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/websocket/websocket-server.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js
  • test/js/web/websocket/websocket.test.js

View test output

#750b1a5482fc7cc15a61d15a1c5ff6a1176318d9

@Jarred-Sumner Jarred-Sumner merged commit c7cc618 into main Jul 2, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-fd-leak branch July 2, 2023 04:58
Jarred-Sumner added a commit that referenced this pull request Jul 3, 2023
@Jarred-Sumner
Fix leak in fd (#3487)
325e7b9 
* Fix file descriptor leak

* Skip unnecessary clone

* Don't break --hot

---------

Co-authored-by: Jarred Sumner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jarred-Sumner