Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified event loop #3741

Merged
merged 6 commits into from
Jul 22, 2023
Merged

Unified event loop #3741

merged 6 commits into from
Jul 22, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner commented Jul 22, 2023

This makes it so JavaScriptCore schedules tasks to Bun's event loop, instead of Bun's event loop periodically checking if JavaScriptCore's event loop has any work to do.

This properly fixes #3524

Fixes #2353
Fixes #1189

A better fix for #127

Surprisingly, does not fix #2732 but I suspect the reproduction's WASM file is invalid

@Jarred-Sumner Jarred-Sumner mentioned this pull request Jul 22, 2023
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@Jarred-Sumner 7 files with test failures on bun-darwin-aarch64:

  • test/bundler/esbuild/ts.test.ts
  • test/cli/install/bun-install.test.ts
  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#5eb0b6054d8673a1c7b3c1a925a82d86b9ddadde

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@Jarred-Sumner 2 files with test failures on linux-x64:

  • test/bundler/esbuild/ts.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#5eb0b6054d8673a1c7b3c1a925a82d86b9ddadde

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

@Jarred-Sumner 2 files with test failures on linux-x64-baseline:

  • test/bundler/esbuild/ts.test.ts
  • test/js/web/fetch/fetch-leak.test.js

View test output

#5eb0b6054d8673a1c7b3c1a925a82d86b9ddadde

@Jarred-Sumner Jarred-Sumner force-pushed the jarred/fix-wasm-load branch from 24b39eb to a240ef5 Compare July 22, 2023 08:05
@github-actions
Copy link
Contributor

@Jarred-Sumner 6 files with test failures on bun-darwin-x64-baseline:

  • test/bundler/esbuild/ts.test.ts
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/bun/util/sleepSync.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#5eb0b6054d8673a1c7b3c1a925a82d86b9ddadde

@Jarred-Sumner Jarred-Sumner merged commit c6a3467 into main Jul 22, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-wasm-load branch July 22, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant