Fix bug with PipeWriter on Windows #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
approved these changes
Mar 29, 2024
|
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64: |
|
❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64: |
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline: |
❌🪟 @Jarred-Sumner, there are 13 test regressions on Windows x86_64
|
|
❌ @Jarred-Sumner 2 files with test failures on linux-x64: |
|
Merging because it fixes the console iterator test |
paperclover
pushed a commit
that referenced
this pull request
Mar 30, 2024
Jarred-Sumner
added a commit
that referenced
this pull request
Apr 1, 2024
#5827) * works * works * a * fix zig compiler error * fix things * [autofix.ci] apply automated fixes * a * not done * finish this * [autofix.ci] apply automated fixes * self check * delete committed generated file (#9717) * Fix bug with PipeWriter (#9714) * fix!: do not lookup cwd in which (#9691) * do not lookup cwd in which * fix webkit submodule * fix compilation on linux * feedback * default process.env.NODE_ENV to undefined (#9695) * small changes * [autofix.ci] apply automated fixes * fix(windows) fix node-stream tests/ windows file reader/writer (#9718) * fix canceled onFileRead * report continue errors and fix closing * also fix pipe writer * avoid possible memory leaks * Propagate errors in open --------- Co-authored-by: Jarred Sumner <[email protected]> * posix failures * windows fixes * avoid using c++ labels * add a resolver * fix compile test AGAIN --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Meghan Denny <[email protected]> Co-authored-by: Jarred Sumner <[email protected]> Co-authored-by: Ciro Spaciari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This should fix some tests
How did you verify your code works?
CI