Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 20 upgrade #226

Merged
merged 1 commit into from
Oct 14, 2024
Merged

node 20 upgrade #226

merged 1 commit into from
Oct 14, 2024

Conversation

arbrandes
Copy link
Collaborator

@arbrandes arbrandes commented Oct 10, 2024

As per openedx/public-engineering#267, all Tutor-supported MFEs now work on Node 20, so we're good to switch to the Node 20 image.

Fixes #198

@arbrandes arbrandes changed the base branch from master to nightly October 10, 2024 13:10
@arbrandes arbrandes linked an issue Oct 10, 2024 that may be closed by this pull request
13 tasks
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! And this "just works"?

@DawoudSheraz
Copy link
Contributor

Cool! And this "just works"?

Given my past MFE build experience, I find it hard to believe it is that simple. But hey, it is MFE. Anything can happen in this verse. I will test it locally in a while.

@@ -0,0 +1,2 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the empty line in the changelog.

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mfe image is building with this change, nice one 👍🏽

Copy link
Contributor

@hinakhadim hinakhadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image is building successfully with this change.

@regisb regisb merged commit eb2ecda into overhangio:nightly Oct 14, 2024
2 checks passed
@arbrandes arbrandes deleted the node-20-upgrade branch December 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update tutor-mfe to use Node 20
4 participants