Skip to content

Commit

Permalink
fix: site name limited to 50 characters (#1145)
Browse files Browse the repository at this point in the history
Before this, building organizations with longer URLs failed since the
name field inside Site model has a max_length=50

Close #1144
  • Loading branch information
CodeWithEmad authored Oct 24, 2024
1 parent 97e9fa4 commit 2440970
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/20241023_155157_codewithemad_long_domain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Bugfix] Fixed an issue where the site name was not limited to 50 characters when creating a new site configuration. (by @CodeWithEmad)
4 changes: 3 additions & 1 deletion tutor/templates/build/openedx/bin/site-configuration
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ def get_site_configuration(domain):
domain = domain or settings.LMS_BASE
site, site_created = Site.objects.get_or_create(domain=domain)
if site_created:
site.name = domain
# Limit the site name to 50 characters
# https://github.com/django/django/blob/4.2.16/django/contrib/sites/models.py#L86
site.name = domain[:50]
site.save()
configuration, configuration_created = SiteConfiguration.objects.get_or_create(site=site)
if configuration_created:
Expand Down

0 comments on commit 2440970

Please sign in to comment.