Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ubuntu #1117

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat: update ubuntu #1117

merged 3 commits into from
Oct 25, 2024

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Sep 3, 2024 •
edited
Loading

Description

Upgrade Open edX image to use Ubuntu 24.04 22.04 (See #1114 (comment) for context on 24.04 -> 22.04 switch).

@DawoudSheraz DawoudSheraz mentioned this pull request Oct 8, 2024
Closed
@DawoudSheraz DawoudSheraz force-pushed the dsheraz/ubuntu-upgrade branch 2 times, most recently from 3e9da87 to 89219b1 Compare October 10, 2024 07:32
@DawoudSheraz DawoudSheraz marked this pull request as ready for review October 10, 2024 07:55
@DawoudSheraz DawoudSheraz changed the title [WIP] feat: update ubuntu feat: update ubuntu Oct 10, 2024
This was referenced Oct 15, 2024
Merged
Merged
regisb
regisb approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kdmccormick
Copy link
Collaborator

2U found an issue with 24.04 (which I don't yet understand) that led them to pin edx-platform tests back to 22.04: openedx/edx-platform#35635

I'm going to ask them about it tomorrow morning at Maintenance WG. Perhaps we hold off until edx-platform is back to testing on 24.04?

@DawoudSheraz
Copy link
Contributor Author

2U found an issue with 24.04 (which I don't yet understand) that led them to pin edx-platform tests back to 22.04: openedx/edx-platform#35635

I'm going to ask them about it tomorrow morning at Maintenance WG. Perhaps we hold off until edx-platform is back to testing on 24.04?

Sure. @regisb FYI

@DawoudSheraz
Copy link
Contributor Author

@kdmccormick Hi, I have updated the PR to use Ubuntu 22.04. Please take another look. Thanks

kdmccormick
kdmccormick approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DawoudSheraz . The diff looks good to me.

I'm going to manually test the build later today when my internet connection is better, but if you have already manually tested it and feel solid about the upgrade, then feel free to merge first.

@DawoudSheraz DawoudSheraz merged commit 7e68baa into nightly Oct 25, 2024
2 checks passed
@feanil feanil mentioned this pull request Nov 12, 2024
Closed
@regisb regisb deleted the dsheraz/ubuntu-upgrade branch November 21, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@regisb regisb regisb approved these changes

Assignees

@DawoudSheraz DawoudSheraz

@Faraz32123 Faraz32123

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DawoudSheraz @kdmccormick @regisb @Faraz32123