-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new tutor dev attach command to attach running containers for debugging #1152
base: release
Are you sure you want to change the base?
feat: add a new tutor dev attach command to attach running containers for debugging #1152
Conversation
Thanks for the PR Danyal! This is a problem I have noticed on Ubuntu as well. I'm able to attach to an individual container's stdout by doing, for example, I'm not super keen to add a new command, but breakpoint debugging is definitely something we all need. I'll test this out and leave a review soon. |
I was hoping I was the only one who observed that issue... EDIT: actually,
|
@regisb, I get the same error as you do which prompted me to make this PR. I also initially thought that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working great for me. Can you update those dev docs that I linked in my comment above?
EDIT: In the dev docs, please also mention that the way to detach from the container without shutting it down is to send Ctrl-p Ctrl-q
.
changelog.d/20241105_162158_danyal.faheem_add_dev_attach_command.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle McCormick <[email protected]>
cf149e6
to
e54b670
Compare
Hey @kdmccormick, I've updated the docs as well. Can you take another look and let me know what you think? |
6f2a518
to
5848679
Compare
Based on my experience, it seems that |
@regisb , I really like that idea, especially since I cannot imagine any situation where I run There is only one minor problem:
If we went with your proposal, that would mean that What do you think @regisb , go forward with modifying |
Yes, I think we should do that. I honestly didn't know about escape commands, as I just ctrl+c all the time. In the process I just discovered that we also need to ctrl+p+q on So my vote goes to changing the "start" command. Especially since it's so easy to run |
Edx-platform developers regularly utilize debuggers inside their codebase and the
tutor dev start
command does not allow attaching to containers on certain OSes such as MacOS. This command will allow users to attach a single running container using thedocker compose attach
command.Caveats: