Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change version suffix to 'main' and load plugins from their main branches #1154

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Change version suffix to 'main' and load plugins from their main branches #1154

merged 2 commits into from
Nov 27, 2024

Conversation

kdmccormick
Copy link
Collaborator

@kdmccormick kdmccormick commented Nov 7, 2024 •
edited
Loading

This PR contains the #1153, plus two Nightly-specific (aka Main-specific) commits:

  • Change version suffix from nightly to main. As indicated in the linked PR's changelog entry, this is a breaking change, as it will rename the default TUTOR_ROOT and TUTOR_PLUGINS_ROOT.
  • Load plugins from main branches rather than nightly branches. This is a safe changes as long as the plugins have already renamed their branches. If they haven't, then pop this commit off and merge it in later.

This was referenced Nov 7, 2024
Merged
Closed
Closed
@kdmccormick kdmccormick force-pushed the kdmccormick/branch-rename-nightly branch from d10b7e9 to 374d5c0 Compare November 27, 2024 06:09
@kdmccormick kdmccormick changed the title feat!: Change version suffix from 'nightly' to 'next' Change version suffix to 'main' and load plugins from their main branches Nov 27, 2024
@kdmccormick kdmccormick marked this pull request as ready for review November 27, 2024 06:13
@regisb regisb force-pushed the kdmccormick/branch-rename-nightly branch from 374d5c0 to 05fefde Compare November 27, 2024 16:58
@regisb regisb force-pushed the kdmccormick/branch-rename-nightly branch from 05fefde to 5691429 Compare November 27, 2024 16:59
regisb
regisb approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogogo!

@regisb regisb merged commit 3116025 into main Nov 27, 2024
2 checks passed
@regisb regisb deleted the kdmccormick/branch-rename-nightly branch November 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdmccormick @regisb