Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: word "Filters" was left out in the Hooks catalog documentation #886

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

CodeWithEmad
Copy link
Member

in the Hooks catalog, the word "Filters" was left out in the documentation.
here:

hooks.CLI_DO_INIT_TASKS.add_item(("lms", "echo hello"))

and here:
hooks.CLI_DO_INIT_TASKS.add_items(

I also had a change log entry, related to docs, so I've added this to it.

@CodeWithEmad CodeWithEmad changed the title Fix: Docs docs: word "Filters" was left out in the Hooks catalog documentation Aug 7, 2023
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just get rid of the changelog changes.

changelog.d/20230801_201804_codewithemad_remove_wizard.md Outdated Show resolved Hide resolved
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR :) it's a tiny change but it's useful!

@regisb regisb merged commit ef30dbc into overhangio:master Aug 14, 2023
1 check passed
@CodeWithEmad
Copy link
Member Author

Happy to be a part of this 🤘

@CodeWithEmad CodeWithEmad deleted the fix/docs branch August 14, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants