fix(cdn): processLogs rollback (#5276)

engine/api/observability/init.go

@@ -38,6 +38,7 @@ func StatsHTTPExporter() *HTTPExporter {
 
 // Init the opencensus exporter
 func Init(ctx context.Context, cfg Configuration, s service) (context.Context, error) {
+	log.Info(ctx, "observability> initializing observability for %s/%s", s.Type(), s.Name())
 	ctx = ContextWithTag(ctx,
 		TagServiceType, s.Type(),
 		TagServiceName, s.Name(),

engine/api/status.go

@@ -220,7 +220,7 @@ func (api *API) initMetrics(ctx context.Context) error {
 		"number of failed workflow runs",
 		stats.UnitDimensionless)
 	api.Metrics.DatabaseConns = stats.Int64(
-		fmt.Sprintf("cds/cds-api/%s/database_conn°", api.Name()),
+		fmt.Sprintf("cds/cds-api/%s/database_conn", api.Name()),
 		"number database connections",
 		stats.UnitDimensionless)
 
@@ -258,6 +258,12 @@ func (api *API) initMetrics(ctx context.Context) error {
 }
 
 func (api *API) computeMetrics(ctx context.Context) {
+	tags := observability.ContextGetTags(ctx, observability.TagServiceType, observability.TagServiceName)
+	ctx, err := tag.New(ctx, tags...)
+	if err != nil {
+		log.Error(ctx, "api.computeMetrics> unable to tag observability context: %v", err)
+	}
+
 	sdk.GoRoutine(ctx, "api.computeMetrics", func(ctx context.Context) {
 		tick := time.NewTicker(9 * time.Second).C
 		for {

engine/cdn/cdn_log.go

@@ -180,16 +180,17 @@ func (s *Service) processLogs(ctx context.Context, chanMessages <-chan handledMe
 				log.Error(ctx, "unable to start tx: %v", err)
 				continue
 			}
-			defer tx.Rollback() // nolint
 
 			currentLog := buildMessage(msg.signature, msg.m)
 			if err := s.processLog(ctx, tx, msg.signature, currentLog); err != nil {
 				log.Error(ctx, "unable to process log: %+v", err)
+				tx.Rollback() // nolint
 				continue
 			}
 
 			if err := tx.Commit(); err != nil {
 				log.Error(ctx, "unable to commit tx: %+v", err)
+				tx.Rollback() // nolint
 				continue
 			}