fix(api): remove noEnv environment (#5452)

Signed-off-by: Yvonnick Esnault <[email protected]>

engine/api/bootstrap/bootstrap.go

@@ -8,7 +8,6 @@ import (
 	"github.com/go-gorp/gorp"
 
 	"github.com/ovh/cds/engine/api/action"
-	"github.com/ovh/cds/engine/api/environment"
 	"github.com/ovh/cds/engine/api/group"
 	"github.com/ovh/cds/engine/api/integration"
 	"github.com/ovh/cds/engine/api/workflow"
@@ -41,10 +40,6 @@ func InitiliazeDB(ctx context.Context, defaultValues sdk.DefaultValues, DBFunc f
 		return sdk.WrapError(err, "Cannot setup builtin actions")
 	}
 
-	if err := environment.CreateBuiltinEnvironments(tx); err != nil {
-		return sdk.WrapError(err, "Cannot setup builtin environments")
-	}
-
 	if err := tx.Commit(); err != nil {
 		return sdk.WithStack(err)
 	}

engine/api/environment/environment.go

@@ -2,7 +2,6 @@ package environment
 
 import (
 	"database/sql"
-	"fmt"
 	"time"
 
 	"github.com/go-gorp/gorp"
@@ -109,9 +108,6 @@ func Lock(db gorp.SqlExecutor, projectKey, envName string) error {
 
 // LoadEnvironmentByID load the given environment
 func LoadEnvironmentByID(db gorp.SqlExecutor, ID int64) (*sdk.Environment, error) {
-	if ID == sdk.DefaultEnv.ID {
-		return &sdk.DefaultEnv, nil
-	}
 	var env sdk.Environment
 	query := `
     SELECT environment.id, environment.name, environment.project_id, environment.created,
@@ -132,10 +128,6 @@ func LoadEnvironmentByID(db gorp.SqlExecutor, ID int64) (*sdk.Environment, error
 
 // LoadEnvironmentByName load the given environment
 func LoadEnvironmentByName(db gorp.SqlExecutor, projectKey, envName string) (*sdk.Environment, error) {
-	if envName == "" || envName == sdk.DefaultEnv.Name {
-		return &sdk.DefaultEnv, nil
-	}
-
 	var env sdk.Environment
 	query := `
     SELECT environment.id, environment.name, environment.project_id, environment.created,
@@ -186,28 +178,6 @@ func Exists(db gorp.SqlExecutor, projectKey, envName string) (bool, error) {
 	return n == 1, nil
 }
 
-// CheckDefaultEnv create default env if not exists
-func CheckDefaultEnv(db gorp.SqlExecutor) error {
-	var env sdk.Environment
-	query := `SELECT environment.id, environment.name FROM environment WHERE environment.id = $1`
-	err := db.QueryRow(query, sdk.DefaultEnv.ID).Scan(&env.ID, &env.Name)
-	if err != nil {
-		if err == sql.ErrNoRows {
-			query := `INSERT INTO environment (name) VALUES($1) RETURNING id`
-			if err1 := db.QueryRow(query, sdk.DefaultEnv.Name).Scan(&env.ID); err1 != nil {
-				return err1
-			} else if env.ID != sdk.DefaultEnv.ID {
-				return sdk.WithStack(fmt.Errorf("default env created but with wrong id, please check db"))
-			}
-			return nil
-		}
-		return err
-	} else if env.ID != sdk.DefaultEnv.ID || env.Name != sdk.DefaultEnv.Name {
-		return sdk.WithStack(fmt.Errorf("default env exists but with wrong id or name, please check db"))
-	}
-	return nil
-}
-
 func loadDependencies(db gorp.SqlExecutor, env *sdk.Environment) error {
 	variables, err := LoadAllVariables(db, env.ID)
 	if err != nil {

engine/api/group/node_group.go

@@ -60,10 +60,6 @@ func InsertGroupsInNode(db gorp.SqlExecutor, groupPermission []sdk.GroupPermissi
 
 // insertGroupInNode add permissions on Node to Group
 func insertGroupInNode(db gorp.SqlExecutor, nodeID, groupID int64, role int) error {
-	// avoid insert default env
-	if sdk.DefaultEnv.ID == nodeID {
-		return nil
-	}
 	query := `INSERT INTO workflow_node_group (workflow_node_id, workflow_group_id, role)
 		VALUES(
 			$1,

sdk/environment.go

@@ -121,9 +121,3 @@ func NewEnvironment(name string) *Environment {
 	}
 	return e
 }
-
-// DefaultEnv Default environment for pipeline build
-var DefaultEnv = Environment{
-	ID:   1,
-	Name: "NoEnv",
-}