fix(api): stop ticker + time.sleep to reduce cpu load (#5304)

ovh · Jul 7, 2020 · b64bba5 · b64bba5
1 parent dae0ac7
commit b64bba5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/engine/api/cache/redis.go b/engine/api/cache/redis.go
@@ -233,10 +233,11 @@ func (s *RedisStore) DequeueWithContext(c context.Context, queueName string, wai
 	}
 
 	var elem string
-	ticker := time.NewTicker(waitDuration).C
+	ticker := time.NewTicker(waitDuration)
+	defer ticker.Stop()
 	for elem == "" {
 		select {
-		case <-ticker:
+		case <-ticker.C:
 			if c.Err() != nil {
 				return c.Err()
 			}

diff --git a/engine/cdn/cdn_log.go b/engine/cdn/cdn_log.go
@@ -277,13 +277,11 @@ func (s *Service) getHatchery(ctx context.Context, hatcheryID int64, hatcheryNam
 }
 
 func (s *Service) waitingJobs(ctx context.Context) {
-	tick := time.NewTicker(250 * time.Millisecond)
-	defer tick.Stop()
 	for {
 		select {
 		case <-ctx.Done():
 			return
-		case _ = <-tick.C:
+		default:
 			// List all queues
 			keyListQueue := cache.Key(keyJobLogQueue, "*")
 			listKeys, err := s.Cache.Keys(keyListQueue)
@@ -312,6 +310,7 @@ func (s *Service) waitingJobs(ctx context.Context) {
 					}
 				})
 			}
+			time.Sleep(250 * time.Millisecond)
 		}
 	}
 }
@@ -332,6 +331,7 @@ func (s *Service) dequeueJobMessages(ctx context.Context, jobLogsQueueKey string
 	}()
 
 	tick := time.NewTicker(5 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-ctx.Done():