Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): add retry on postWorkflowJobTestsResultsHandler #3581

Closed
fsamin opened this issue Nov 12, 2018 · 0 comments
Closed

fix(worker): add retry on postWorkflowJobTestsResultsHandler #3581

fsamin opened this issue Nov 12, 2018 · 0 comments

Comments

@fsamin
Copy link
Member

fsamin commented Nov 12, 2018

pprofLabel>recoverWrap>Handle>postWorkflowJobTestsResultsHandler>LoadAndLockNodeRunByID: internal server error (caused by: Cannot load node job: Unable to load workflow_node_run node=2604599: pq: could not obtain lock on row in relation "workflow_node_run")

we should handle the pq error pq: could not obtain lock on row in relation "workflow_node_run"to handle retry on all client function retries on this kind of error at client http level

func (c *client) QueueSendResult(ctx context.Context, id int64, res sdk.Result) error {
	path := fmt.Sprintf("/queue/workflows/%d/result", id)
	_, err := c.PostJSON(ctx, path, res, nil)
	return err
}
bnjjj added a commit that referenced this issue Nov 13, 2018
bnjjj added a commit that referenced this issue Nov 13, 2018
@bnjjj bnjjj closed this as completed in 4fe015e Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant