Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a pipeline with notifications on it #5055

Closed
yesnault opened this issue Mar 10, 2020 · 0 comments · Fixed by #5463
Closed

Delete a pipeline with notifications on it #5055

yesnault opened this issue Mar 10, 2020 · 0 comments · Fixed by #5463
Assignees
@fsamin
Labels
feature ui

Comments

@yesnault
Copy link
Member

Today: a user can remove a pipeline from the web ui. If there is a notification on it, the notification is deleted too. It's normal.

But, it could be great to alert the user "this pipeline contains a notification on it, are you sure you want to delete it?"
@fsamin fsamin self-assigned this Sep 30, 2020
fsamin added a commit that referenced this issue Sep 30, 2020
@fsamin
fix(ui): edit notifications
49eadc1 
close #5055, #5290

Signed-off-by: francois  samin <[email protected]>
@fsamin fsamin mentioned this issue Sep 30, 2020
Merged
fsamin added a commit that referenced this issue Oct 1, 2020
@fsamin
fix(ui): edit notifications
939cd55 
close #5055, #5290

Signed-off-by: francois  samin <[email protected]>
sguiheux pushed a commit that referenced this issue Oct 2, 2020
@fsamin
fix(ui): edit notifications (#5463)
bf55821 
close #5055, #5290

Signed-off-by: francois  samin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsamin fsamin

Labels
feature ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): edit notifications ovh/cds
2 participants
@yesnault @fsamin