feat (api): add release builtin action #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
requested changes
Sep 5, 2017
|
|
||
| res, err := g.post(url, "application/json", bytes.NewBuffer(b), false) | ||
| if err != nil { | ||
| return nil, err |
engine/api/workflow_application.go
Outdated
| "github.com/go-gorp/gorp" | ||
| "github.com/gorilla/mux" | ||
|
|
||
| "bufio" |
engine/api/workflow_application.go
Outdated
| return errU | ||
| } | ||
|
|
||
| router.Handle("/project/{permProjectKey}/workflows/{workflowName}/runs/{number}/nodes/{id}/release", POST(releaseApplicationWorkflowHandler)) |
engine/api/workflow_application.go
Outdated
|
|
||
| for _, a := range artifactToUpload { | ||
| b := &bytes.Buffer{} | ||
| writer := bufio.NewWriter(b) |
yesnault
requested changes
Sep 5, 2017
engine/api/action/builtin.go
Outdated
| gitrelease.Parameter(sdk.Parameter{ | ||
| Name: "releaseNote", | ||
| Description: "Set a release note for the release", | ||
| Type: sdk.StringParameter, |
engine/api/action/builtin.go
Outdated
| }) | ||
| gitrelease.Parameter(sdk.Parameter{ | ||
| Name: "artifacts", | ||
| Description: "Set a list of artifacts, separate by , .", |
engine/api/action/builtin.go
Outdated
| gitrelease.Parameter(sdk.Parameter{ | ||
| Name: "artifacts", | ||
| Description: "Set a list of artifacts, separate by , .", | ||
| Type: sdk.StringParameter, |
|
|
||
| // Release Create a release Github | ||
| func (g *GithubClient) Release(fullname string, tagName string, title string, releaseNote string) (*sdk.VCSRelease, error) { | ||
| var url = "/repos/" + fullname + "/releases" |
sdk/cdsclient/client_workflow.go
Outdated
| return err | ||
| } | ||
| if code >= 300 { | ||
| return fmt.Errorf("Cannot create workflow node run release") |
There was a problem hiding this comment.
display http code ? (and body err ?)
bnjjj
approved these changes
Sep 5, 2017
| tmp["cds.run"] = fmt.Sprintf("%d.%d", 1, 0) | ||
| tmp["cds.run.number"] = fmt.Sprintf("%d", 1) | ||
| tmp["cds.run.subnumber"] = fmt.Sprintf("%d", 0) | ||
| // TODO Update suggest.go with new variable |
There was a problem hiding this comment.
it's not for me ;)
fsamin
approved these changes
Sep 5, 2017
yesnault
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.