fix(api): load old workflow before changing anything in database #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlt
requested review from
bnjjj,
fsamin,
sguiheux and
yesnault
as code owners
|
CDS Report it#7722.0 ✘
|
…est case for put endpoint that should not create the workflow
bnjjj
approved these changes
Dec 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract workflow loading out of import func and load the workflow before using workflow ParseAndImport.
This will avoid problems to load the workflow when its components were already updated (ex: workflow.Push make changes on application before loading the workflow, this will generate an error if you remove a deployment strategy on an application).
Related issues
fix(api): push load old workflow with updated project data #3763
About tests
Create the workflow before updating it for put workflow endpoint. The put workflow will not create the workflow anymore.
Mentions
@ovh/cds