fix(worker): remove trailing '=' from working dir #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why : some makefile can try to interprete '=' in path. ex : OBJS = $(SRCS:$(SRCS_DIR)/%.c=$(OBJDIR)/%.o) if SRCS_DIR contains '=' this fail to create the list of objs Even if it should be up to the build script to manage this. This commit will prevent this kind of tricky issue. How : use RawStdEncoding instead of StdEncoding RawStdEncoding is the standard raw, unpadded base64 encod
skeetmtp
requested review from
bnjjj,
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
yesnault
approved these changes
Jan 14, 2019
richardlt
approved these changes
Jan 14, 2019
bnjjj
approved these changes
Jan 15, 2019
fsamin
approved these changes
Jan 15, 2019
sguiheux
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why : some makefile can try to interprete '=' in path.$(SRCS:$ (SRCS_DIR)/%.c=$(OBJDIR)/%.o)
ex : OBJS =
if SRCS_DIR contains '=' this fail to create the list of objs
Even if it should be up to the build script to manage this.
This commit will prevent this kind of tricky issue.
How : use RawStdEncoding instead of StdEncoding
RawStdEncoding is the standard raw, unpadded base64 encod