Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): purge workflow audits #3954

Merged
merged 1 commit into from
Feb 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions engine/api/workflow/audit.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"encoding/json"
"fmt"
"strings"
"time"

"github.com/go-gorp/gorp"
"github.com/mitchellh/mapstructure"
Expand All @@ -31,6 +32,8 @@ var (
func ComputeAudit(c context.Context, DBFunc func() *gorp.DbMap) {
chanEvent := make(chan sdk.Event)
event.Subscribe(chanEvent)
deleteTicker := time.NewTicker(15 * time.Minute)
defer deleteTicker.Stop()

db := DBFunc()
for {
Expand All @@ -40,6 +43,10 @@ func ComputeAudit(c context.Context, DBFunc func() *gorp.DbMap) {
log.Error("ComputeWorkflowAudit> Exiting: %v", c.Err())
return
}
case <-deleteTicker.C:
if err := purgeAudits(DBFunc()); err != nil {
log.Error("ComputeWorkflowAudit> Purge error: %v", c)
}
case e := <-chanEvent:
if !strings.HasPrefix(e.EventType, "sdk.EventWorkflow") {
continue
Expand Down Expand Up @@ -221,3 +228,38 @@ func (a deleteWorkflowPermissionAudit) Compute(db gorp.SqlExecutor, e sdk.Event)
WorkflowID: wEvent.WorkflowID,
})
}

const keepAudits = 50

func purgeAudits(db gorp.SqlExecutor) error {
var nbAuditsPerWorkflowID = []struct {
WorkflowID int64 `db:"workflow_id"`
NbAudits int64 `db:"nb_audits"`
}{}

query := `select workflow_id, count(id) "nb_audits" from workflow_audit group by workflow_id having count(id) > $1`
if _, err := db.Select(&nbAuditsPerWorkflowID, query, keepAudits); err != nil {
return sdk.WithStack(err)
}

for _, r := range nbAuditsPerWorkflowID {
log.Debug("purgeAudits> deleting audits for workflow %d (%d audits)", r.WorkflowID, r.NbAudits)
var ids []int64
query = `select id from workflow_audit where workflow_id = $1 order by created asc offset $2`
if _, err := db.Select(&ids, query, r.WorkflowID, keepAudits); err != nil {
return sdk.WithStack(err)
}
for _, id := range ids {
if err := deleteAudit(db, id); err != nil {
log.Error("purgeAudits> unable to delete audit %d: %v", id, err)
}
}
}

return nil
}

func deleteAudit(db gorp.SqlExecutor, id int64) error {
_, err := db.Exec(`delete from workflow_audit where id = $1`, id)
return sdk.WithStack(err)
}
16 changes: 16 additions & 0 deletions engine/api/workflow/audit_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package workflow

import (
"testing"

"github.com/ovh/cds/engine/api/bootstrap"
"github.com/ovh/cds/engine/api/test"
)

func Test_purgeAudits(t *testing.T) {
db, _, end := test.SetupPG(t, bootstrap.InitiliazeDB)
defer end()

err := purgeAudits(db)
test.NoError(t, err)
}