Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version 2 of workflow export entities #5021

Merged
merged 22 commits into from
Mar 9, 2020
Merged

feat: add version 2 of workflow export entities #5021

merged 22 commits into from
Mar 9, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Feb 27, 2020 •
edited
Loading

  1. Description
  • Remove one pipeline mode
  • Use a slice for notifications
  • Display warning when load v1.0 workflow
  1. Related issues
  2. About tests
  3. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 27, 2020

CDS Report build-all-cds#12568.0 ✘

  • Build
    • Build and Package All ✘
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✘
    • Test Engine ✘
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12577.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12579.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12582.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12582.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12583.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 28, 2020

CDS Report build-all-cds#12586.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2020

CDS Report build-all-cds#12598.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2020

CDS Report build-all-cds#12598.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2020

CDS Report build-all-cds#12598.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 2, 2020

CDS Report build-all-cds#12605.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 3, 2020

CDS Report build-all-cds#12623.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux marked this pull request as ready for review March 3, 2020 14:05
@sguiheux sguiheux requested a review from yesnault as a code owner March 3, 2020 14:05
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 3, 2020

CDS Report build-all-cds#12645.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

fsamin
fsamin requested changes Mar 5, 2020
View reviewed changes
engine/api/workflow/workflow_exporter.go Outdated Show resolved Hide resolved
engine/api/user_schema.go Outdated Show resolved Hide resolved
engine/api/workflow/as_code.go Outdated Show resolved Hide resolved
engine/api/workflow/workflow_parser.go Show resolved Hide resolved
engine/api/workflow_export_test.go Show resolved Hide resolved
engine/api/workflow/execute_node_run.go Show resolved Hide resolved
engine/api/workflow.go Outdated Show resolved Hide resolved
sdk/exportentities/v1/workflow.go Show resolved Hide resolved
sdk/exportentities/v1/workflow.go Show resolved Hide resolved
bnjjj
bnjjj suggested changes Mar 5, 2020
View reviewed changes
sdk/exportentities/v2/workflow.go Outdated Show resolved Hide resolved
sdk/exportentities/v2/workflow.go Show resolved Hide resolved
sdk/exportentities/v2/workflow.go Outdated Show resolved Hide resolved
sdk/messages.go Outdated Show resolved Hide resolved
ui/src/app/views/workflow/run/errors.ts Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 5, 2020

CDS Report build-all-cds#12678.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✘
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 5, 2020

CDS Report build-all-cds#12679.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@sguiheux sguiheux requested review from bnjjj and fsamin March 5, 2020 09:16
fsamin
fsamin requested changes Mar 5, 2020
View reviewed changes
engine/api/workflow.go Outdated Show resolved Hide resolved
fsamin
fsamin requested changes Mar 5, 2020
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@sguiheux sguiheux requested a review from fsamin March 5, 2020 13:40
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 5, 2020

CDS Report build-all-cds#12693.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✘
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 9, 2020

CDS Report build-all-cds#12693.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
    • Docs ✔
  • Integration
    • Docker Compose Tests ✔
    • Helm Tests -
    • Standalone Tests ✘

@fsamin fsamin merged commit eb3c114 into master Mar 9, 2020
@sguiheux sguiheux deleted the v2ExportEntitiesWorkflow branch April 10, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjjj bnjjj bnjjj approved these changes

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt @bnjjj