fix(api): Allow to get every service through getServiceHandler #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesnault
approved these changes
May 11, 2020
fsamin
approved these changes
May 11, 2020
|
CDS Report build-all-cds#13214.0 ✘
|
richardlt
requested changes
May 11, 2020
| if err != nil { | ||
| return actionplugin.Fail("Unable to get clair configuration: %s", err) | ||
| } | ||
| serv := servs[0] |
| @@ -423,7 +423,7 @@ func (api *API) InitRouter() { | |||
| // Engine µServices | |||
| r.Handle("/services/register", Scope(sdk.AuthConsumerScopeService), r.POST(api.postServiceRegisterHandler, MaintenanceAware())) | |||
| r.Handle("/services/heartbeat", Scope(sdk.AuthConsumerScopeService), r.POST(api.postServiceHearbeatHandler)) | |||
| r.Handle("/services/{type}", Scope(sdk.AuthConsumerScopeService), r.GET(api.getExternalServiceHandler)) | |||
There was a problem hiding this comment.
/services?type=clair should be better no ?
| @@ -11,8 +12,26 @@ import ( | |||
| "github.com/ovh/cds/sdk/log" | |||
| ) | |||
|
|
|||
| // ExternalService represents an external service | |||
| type ExternalService struct { | |||
| sdk.Service `json:"-"` | |||
| @@ -11,8 +12,26 @@ import ( | |||
| "github.com/ovh/cds/sdk/log" | |||
| ) | |||
|
|
|||
| // ExternalService represents an external service | |||
| type ExternalService struct { | |||
There was a problem hiding this comment.
I think this type can be removed, ServiceConfiguration will be enough.
richardlt
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ovh/cds