Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): variables dao #5235

Merged
merged 7 commits into from
Jun 11, 2020
Merged

refactor(api): variables dao #5235

merged 7 commits into from
Jun 11, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jun 5, 2020 •
edited
Loading

NEED #4975

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 5, 2020

CDS Report build-all-cds#13493.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@fsamin fsamin changed the title feat(api): refact variables dao refactor(api): variables dao Jun 5, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

62.4% 62.4% Coverage
0.0% 0.0% Duplication

@sguiheux sguiheux merged commit 5d198e3 into master Jun 11, 2020
@sguiheux sguiheux deleted the refactVariablesDAO branch June 17, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt