Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hook): check error to avoid panic #5259

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix(hook): check error to avoid panic #5259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions engine/hooks/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,15 +139,15 @@ func executeWebHook(t *sdk.TaskExecution) (*sdk.WorkflowNodeRunHookEvent, error)
}
//Parse the content type
ct, _, _ = mime.ParseMediaType(ct)
switch {
case ct == "application/x-www-form-urlencoded":
switch ct {
case "application/x-www-form-urlencoded":
formValues, err := url.ParseQuery(string(t.WebHook.RequestBody))
if err == nil {
if err != nil {
return nil, sdk.WrapError(err, "Unable webhook to parse body %s", t.WebHook.RequestBody)
}
copyValues(values, formValues)
h.Payload["payload"] = string(t.WebHook.RequestBody)
case ct == "application/json":
case "application/json":
var bodyJSON interface{}

//Try to parse the body as an array
Expand Down