Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): migrate to angular 11 #5576

Merged
merged 8 commits into from
Dec 3, 2020
Merged

feat(ui): migrate to angular 11 #5576

merged 8 commits into from
Dec 3, 2020

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Dec 2, 2020

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 2, 2020

CDS Report build-all-cds#15021.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 2, 2020

CDS Report build-all-cds#15022.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✘

fsamin
fsamin requested changes Dec 2, 2020
View reviewed changes
ui/src/app/app.module.ts Outdated Show resolved Hide resolved
ui/src/app/store/applications.state.spec.ts Outdated Show resolved Hide resolved
@sguiheux sguiheux requested a review from fsamin December 2, 2020 16:40
@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 2, 2020

CDS Report build-all-cds#15028.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2020 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ovh-cds
Copy link
Collaborator

ovh-cds commented Dec 3, 2020

CDS Report build-all-cds#15031.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Docs -
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package and Analyze
    • Docker ✔
    • Sonar ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sguiheux sguiheux merged commit d2a558a into master Dec 3, 2020
@sguiheux sguiheux deleted the ng11 branch December 30, 2020 09:12
@sguiheux sguiheux restored the ng11 branch December 30, 2020 09:12
@sguiheux sguiheux deleted the ng11 branch December 30, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt