Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdn): do not select all database for item unit purge #5739

Merged
merged 5 commits into from
Mar 5, 2021
Merged

fix(cdn): do not select all database for item unit purge #5739

merged 5 commits into from
Mar 5, 2021

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Mar 4, 2021

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

richardlt
richardlt requested changes Mar 4, 2021
View reviewed changes
engine/cdn/storage/storageunit.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 4, 2021

CDS Report build-all-cds#15709.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@fsamin fsamin changed the title fix: do not select all database fix(cdn): do not select all database for item unit purge Mar 4, 2021
@fsamin
Copy link
Member

fsamin commented Mar 4, 2021

please try to write more precise commit msg

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 4, 2021

CDS Report build-all-cds#15709.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sguiheux sguiheux requested a review from richardlt March 4, 2021 10:31
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 4, 2021

CDS Report build-all-cds#15713.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 4, 2021

CDS Report build-all-cds#15715.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test SDK Rust ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sguiheux sguiheux merged commit 97bc1ef into master Mar 5, 2021
@sguiheux sguiheux deleted the fixPurge branch March 5, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @fsamin @yesnault @richardlt