refactor: string functions #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butuzov
requested review from
fsamin,
richardlt,
sguiheux and
yesnault
as code owners
this commits attempts to refactor few code lines highlighted while doing static analysis. all of the fixes allows more effective working code. Signed-off-by: Oleg Butuzov <[email protected]>
richardlt
approved these changes
Oct 4, 2021
yesnault
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to refactor few code lines highlighted while doing static analysis.
All of the fixes are done for more effective code, and reducing allocations (while converting)
strings to []byte
@ovh/cds