Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): remove suiPopup #6233

Merged
merged 3 commits into from
Jul 11, 2022
Merged

refactor(ui): remove suiPopup #6233

merged 3 commits into from
Jul 11, 2022

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Jul 8, 2022

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jul 8, 2022

CDS Report build-all-cds#17627.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✘
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sguiheux sguiheux merged commit a3c8ff0 into master Jul 11, 2022
@sguiheux sguiheux deleted the removeSuiPopup branch July 11, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sguiheux @ovh-cds @fsamin @richardlt