Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api, worker): auto build info #6264

Merged
merged 18 commits into from
Sep 2, 2022
Merged

fix(api, worker): auto build info #6264

merged 18 commits into from
Sep 2, 2022

Conversation

fsamin
Copy link
Member

@fsamin fsamin commented Sep 1, 2022

No description provided.

fsamin added 16 commits August 26, 2022 16:42
@fsamin
wip
d1ed4fd 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
1ed05f5 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
554cca5 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
dd08a83 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
15ce98f 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
11972dd 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
ad8d408 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
f4fc524 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
f94534e 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
fd09c8a 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
0dbb8d1 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
7501e65 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
b38e419 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
b354400 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
be87ab8 
Signed-off-by: francois  samin <[email protected]>
@fsamin
wip
c7511ef 
Signed-off-by: francois  samin <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 1, 2022

CDS Report build-all-cds#17834.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

sguiheux
sguiheux requested changes Sep 1, 2022
View reviewed changes
engine/api/workflow_queue.go Outdated
return err
}

var releaseRequest sdk.WorkflowRunResultPromotionRequest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releaseRequest -> promotionRequest

engine/api/workflow_queue.go Outdated
for _, id := range releaseRequest.IDs {
if id == r.ID {
log.Debug(ctx, "adding promotion data: %+v", releaseRequest)
r.DataSync.Promotions = append(r.DataSync.Promotions, releaseRequest.WorkflowRunResultPromotion)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe test if promotion maturity is already in the slice

engine/api/workflow_queue.go
for _, id := range releaseRequest.IDs {
if id == r.ID {
log.Debug(ctx, "adding release data: %+v", releaseRequest)
r.DataSync.Releases = append(r.DataSync.Releases, releaseRequest.WorkflowRunResultPromotion)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

engine/worker/internal/action/builtin_promote.go Outdated
return sdk.Result{Status: sdk.StatusFail}, err
}

log.Info(ctx, "RunRelease> preparing run result %+v for release", promotedRunResultIDs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
log.Info(ctx, "RunRelease> preparing run result %+v for release", promotedRunResultIDs)
log.Info(ctx, "RunPromote> preparing run result %+v for promotion", promotedRunResultIDs)

@fsamin
wip
bda112e 
Signed-off-by: francois  samin <[email protected]>
richardlt
richardlt approved these changes Sep 1, 2022
View reviewed changes
contrib/integrations/artifactory/artifactory.go Outdated
@@ -272,6 +272,7 @@ func PrepareBuildInfo(ctx context.Context, artiClient artifact_manager.ArtifactM
version: r.Version,
projectKey: r.ProjectKey,
}
log.Info(ctx, "compute build infos for %+v", execContext)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug ?

@fsamin
wip
d3df4a2 
Signed-off-by: francois  samin <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2022

CDS Report build-all-cds#17837.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2022

CDS Report build-all-cds#17837.1 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2022

CDS Report build-all-cds#17837.2 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 2, 2022

CDS Report build-all-cds#17837.3 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fsamin fsamin merged commit 88919ef into master Sep 2, 2022
@fsamin fsamin deleted the fix_auto_build_info branch September 19, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fsamin @ovh-cds @yesnault @sguiheux @richardlt