Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add delete workflow run command #6273

Merged
merged 3 commits into from
Sep 12, 2022
Merged

feat(cli): add delete workflow run command #6273

merged 3 commits into from
Sep 12, 2022

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Sep 8, 2022

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

fsamin
fsamin requested changes Sep 8, 2022
View reviewed changes
cli/cdsctl/workflow.go Outdated Show resolved Hide resolved
cli/cdsctl/workflow_run.go Outdated
},
Args: []cli.Arg{
{
Name: "run-number",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i could be a variadic to delete more than one run in a single command

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have nothing to do that with args on the cli.
Like the others command ( workflow stop etc.), it's still easy to write a for loop in bash

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fake news !

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 8, 2022

CDS Report build-all-cds#17877.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sguiheux sguiheux requested a review from fsamin September 8, 2022 13:14
@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 9, 2022

CDS Report build-all-cds#17894.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Sep 9, 2022

CDS Report build-all-cds#17898.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux merged commit 97e6d06 into master Sep 12, 2022
@sguiheux sguiheux deleted the deleteRunCLI branch September 12, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt