Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api,hooks): add manual workflow trigger #6911

Merged
merged 25 commits into from
Mar 26, 2024
Merged

feat(api,hooks): add manual workflow trigger #6911

merged 25 commits into from
Mar 26, 2024

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@sguiheux sguiheux marked this pull request as ready for review March 25, 2024 10:16
@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 25, 2024

CDS Report build-cds#20370.0 ✔
*

  • Build and Package All -
  • Build and Package Contrib Action ✔
  • Build and Package Contrib Code Plugin ✔
  • Build and Package Contrib Integrations ✔
  • Build and Package Engine, Worker, CLI and Doc ✔
  • Build and Package UI ✔
  • Build Debpacker ✔
  • Build SMTPMock ✔
  • Lint UI Translate ✔
  • Test CLI ✔
  • Test Contrib ✔
  • Test Engine ✔
  • Test SDK ✔
  • Test UI ✔

@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh ovh deleted a comment from ovh-cds Mar 25, 2024
@ovh ovh deleted a comment from sonarqubecloud bot Mar 25, 2024
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 25, 2024

CDS Report integration-cds#20370.0 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 25, 2024

CDS Report integration-cds#20370.1 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

yesnault
yesnault requested changes Mar 26, 2024
View reviewed changes
engine/api/api.go
@@ -247,6 +247,9 @@ type Configuration struct {
WorkflowV2 struct {
JobSchedulingTimeout int64 `toml:"jobSchedulingTimeout" comment:"Timeout delay for job scheduling (in seconds)" json:"jobSchedulingTimeout" default:"600"`
} `toml:"workflowv2" comment:"######################\n 'Workflow V2' global configuration \n######################" json:"workflowv2"`
Entity struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing toml annotation

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 26, 2024

CDS Report build-cds#20382.0 ✔
*

  • Build and Package All -
  • Build and Package Contrib Action ✔
  • Build and Package Contrib Code Plugin ✔
  • Build and Package Contrib Integrations ✔
  • Build and Package Engine, Worker, CLI and Doc ✔
  • Build and Package UI ✔
  • Build Debpacker ✔
  • Build SMTPMock ✔
  • Lint UI Translate ✔
  • Test CLI ✔
  • Test Contrib ✔
  • Test Engine ✔
  • Test SDK ✔
  • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 26, 2024

CDS Report integration-cds#20382.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sguiheux sguiheux merged commit 3d3d7e1 into master Mar 26, 2024
4 checks passed
@richardlt richardlt deleted the manualTrigger branch March 28, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@yesnault yesnault yesnault approved these changes

@fsamin fsamin Awaiting requested review from fsamin fsamin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sguiheux @ovh-cds @yesnault @richardlt