Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

Make asserts consistent #321

Closed
wants to merge 1 commit into from
Closed

Make asserts consistent #321

wants to merge 1 commit into from

Conversation

ddmler
Copy link
Collaborator

@ddmler ddmler commented Jan 30, 2017

Hey!

Type: code quality

Link to issue:

This pull request affects the following components (please check boxes):

  • Core
  • Analyzer
  • Compiler
  • Control Flow Graph
  • Documentation

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines.
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

sebastianbergmann/phpunit#1914 (comment)

this should be used instead of a static call.

@ovr
Copy link
Owner

ovr commented Jan 31, 2017

All this methods are static

image

https://github.com/sebastianbergmann/phpunit/blob/5.7/src/Framework/Assert.php#L16

We should use parent::

@ddmler
Copy link
Collaborator Author

ddmler commented Feb 1, 2017

@ovr see my link above for reasons to use this instead.
Official phpunit docs use this too, so we should go with the commonly used way.
parent offers no benefit for us.

@ovr
Copy link
Owner

ovr commented Feb 8, 2017

@ddmler Asked some guys about $this-> instead of parent:: in Twitter
IMHO I think We should use parent::

@ovr
Copy link
Owner

ovr commented Feb 10, 2017

image

@ddmler
Copy link
Collaborator Author

ddmler commented Feb 18, 2017

will create a new PR so closing this

@ddmler ddmler closed this Feb 18, 2017
@ddmler ddmler deleted the test-asserts branch February 18, 2017 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants