ssh: add proxyproto support #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is useful for scenarios in which uptermd is behind a proxy, in order for it to properly show IP addresses associated with ssh connections. Also see https://github.com/haproxy/haproxy/blob/master/doc/proxy-protocol.txt
bretello
commented
Jan 17, 2025
Comment on lines
+104
to
+106
| if opt.ProxyProtocol { | ||
| sshln = &proxyproto.Listener{Listener: sshln} | ||
| } |
There was a problem hiding this comment.
We could similarly wrap the wsln listener below, although in that case there are multiple methods in which the client's real IP address can reported (X-Forwarded-For and X-real-ip headers for example). So I excluded it as out of the scope for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
uptermdthrough a tcp reverse proxy, such as Traefik, the real IP address of ssh clients is masked by the proxy.By leveraging the proxy protocol and goproxyproto, the correct addresscan be reported by uptermd.
This PR adds a
--proxy-protocolflag to enable this feature.An example traefik docker-compose configuration is also provided.