Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dashes from config prefixes #77

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

rynomars
Copy link
Contributor

@rynomars rynomars commented Jun 6, 2024

This PR removes the dashes (-) from the prefixes in the config. When you attempt to use the "xxx-sharp" svg an error is encountered.

The blade-ui component documentation states:

It's also important to note that icon prefixes cannot contain dashes (-) as this is the delimiter which we use to split it from the rest of the icon name.

@danlapteacru
Copy link

I had the same issue. After removing the dashes (-), everything works well.

@owenvoke
Copy link
Owner

Hi @rynomars, apologies for the delay on reviewing this.

I think this makes sense to do (I must have overlooked that - isn't allowed in the prefix).

I'm assuming that, if this has always resulted in an error, no one is already using this in existing apps, so it should be safe to rename these (unless it worked with the @svg directive, or if people used the file directly).

I'm not sure if it looks a bit odd having them named fassharp, etc. but I can't think of a good alternative right now.

@belzaaron
Copy link
Contributor

Hey - just circling back on this. I believe this is still an issue and prevents:

  • Sharp Regular (far-sharp)
  • Sharp Light (fal-sharp)
  • Sharp Solid (fas-sharp)

from being used with the default config alias'.

@owenvoke
Copy link
Owner

Sorry for the delay on this, I assume we can't really use another delimiter. 🤔 If not, I'll merge and release this today. 👍🏻

@owenvoke owenvoke merged commit 8d3ef47 into owenvoke:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants