Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move SuggestedChartRevisionStatus enum to clientUtils #1154

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

marcelgerber
Copy link
Member

This is part 1 of ♾️ of the #1082 work.

I noticed that db had a dependency on adminSiteClient, which is a red flag really. Thankfully, the dependency only existed because of an enum import, and could be resolved by using this type to owidTypes in the bottom clientUtils module.

I also realized that TS project references are transitive (i.e. if A -> B and B -> C, then A can also import modules from C without explicitly listing C), so the project-dependencies.md graph doesn't even reflect all the various interdependencies that we have.

@marcelgerber marcelgerber merged commit 67011d7 into master Feb 14, 2022
@marcelgerber marcelgerber deleted the move-suggested-chart-revision-types branch February 14, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant