refactor: move SuggestedChartRevisionStatus enum to clientUtils #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of ♾️ of the #1082 work.
I noticed that
db
had a dependency onadminSiteClient
, which is a red flag really. Thankfully, the dependency only existed because of an enum import, and could be resolved by using this type toowidTypes
in the bottomclientUtils
module.I also realized that TS project references are transitive (i.e. if A -> B and B -> C, then A can also import modules from C without explicitly listing C), so the
project-dependencies.md
graph doesn't even reflect all the various interdependencies that we have.