Revised getIdentifier method to use oboInOwl#id for non-obolibrary PURLs #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yy20716
commented
Apr 12, 2018
yy20716
commented
- This pull request contains patches that resolve the issue discussed in this post. I also added testcase codes based on the example ontology snippet in that post and confirmed that the codes properly handle all cases discussed. Thank you.
cmungall
added a commit
that referenced
this pull request
May 7, 2018
Ensuring that the getIdentifier fix from #247 is used for all entrypo…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.