Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): bump androidxFragment from 1.5.7 to 1.6.2 #4355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 4, 2024

Bumps androidxFragment from 1.5.7 to 1.6.2.
Updates androidx.fragment:fragment-ktx from 1.5.7 to 1.6.2

Updates androidx.fragment:fragment-testing from 1.5.7 to 1.6.2

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Apr 4, 2024
@Aitorbp Aitorbp self-assigned this Apr 4, 2024
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidxFragment-1.6.2 branch from 181b7aa to ecaddcc Compare April 5, 2024 11:06
@Aitorbp Aitorbp requested a review from JuancaG05 April 5, 2024 11:23
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JuancaG05
Copy link
Collaborator

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 8, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@JuancaG05 JuancaG05 force-pushed the dependabot/gradle/androidxFragment-1.6.2 branch 2 times, most recently from eadb289 to 07daedb Compare April 9, 2024 06:34
dependabot bot and others added 2 commits April 9, 2024 10:09
Bumps `androidxFragment` from 1.5.7 to 1.6.2.

Updates `androidx.fragment:fragment-ktx` from 1.5.7 to 1.6.2

Updates `androidx.fragment:fragment-testing` from 1.5.7 to 1.6.2

---
updated-dependencies:
- dependency-name: androidx.fragment:fragment-ktx
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: androidx.fragment:fragment-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…sActivityTest, LoginActivityTest and PassCodeActivityTest
@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidxFragment-1.6.2 branch from 07daedb to ad35faa Compare April 9, 2024 09:09
@Aitorbp
Copy link
Contributor

Aitorbp commented Apr 9, 2024

We are having problems with Bitrise because it does not pass the tests due to flakies. Therefore we have made a list of the flakies that are being played to ignore them from Bitrise. We have looked at the last 10 worksflows that have failed in bitrise and we have put the tests that have been played the most in order from most to least. In any case all these tests except badge_available_offline_in_image_is_not_viewed_when_file_does_not_change_state will be ignored because they are already known from previous worksflows:

privacyPolicyOpensPrivacyPolicyActivity (7)
test_sort_by_name_click (5)
test_sort_by_date_click (2)
verifyTests (2)
initialViewStatus_brandedOptions_serverInfoInSetup_connectionFails (2)
badge_available_offline_in_image_is_not_viewed_when_file_does_not_change_state (1)
login_isLoading (1)

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 9, 2024

In any case all these tests except badge_available_offline_in_image_is_not_viewed_when_file_does_not_change_state will be ignored because they are already known from previous worksflows:

that one failed 1 out of 10, same as login_isLoading. Why is this one ignored with the same flaky rate as the one you mentioned?

Just as my opinion, i'd ignore only the two on the top.

@Aitorbp
Copy link
Contributor

Aitorbp commented Apr 9, 2024

In any case all these tests except badge_available_offline_in_image_is_not_viewed_when_file_does_not_change_state will be ignored because they are already known from previous worksflows:

that one failed 1 out of 10, same as login_isLoading. Why is this one ignored with the same flaky rate as the one you mentioned?

Just as my opinion, i'd ignore only the two on the top.

Because that one in particular I've never seen it in other past worksflows (maybe appear too more often). For example, the login_isLoading one I've seen many times, although in these last 10 workflows it only appears once.

@Aitorbp Aitorbp force-pushed the dependabot/gradle/androidxFragment-1.6.2 branch from 6d49ac0 to ad35faa Compare April 10, 2024 07:21
@Aitorbp
Copy link
Contributor

Aitorbp commented Apr 12, 2024

This bump is not going to be merged because the bitrise UI Tests are giving a lot of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Estimation - 2 (S)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants