Disable validation of transmission checksums by default #4638 #4663
Conversation
ckamm
force-pushed
the
disabletransmissionchecksum
branch
2 times, most recently
from
5aecbdf to
352f5d2
Compare
* Add checksums/supportedTypes and checksums/preferredUploadType capabilities. The default is that no checksum types are supported. * Remove the transmissionChecksum config option. Servers must now use the capabilities to indicate that they are fine with the client sending checksums. Note: This intentionally breaks brandings that overrode Theme::transmissionChecksum. The override must be removed and the server's capabilities must be adjusted to include the new values.
ckamm
force-pushed
the
disabletransmissionchecksum
branch
from
352f5d2 to
ea40e31
Compare
| @@ -17,6 +17,7 @@ | |||
| #include "syncfileitem.h" | |||
| #include "propagatorjobs.h" | |||
| #include "account.h" | |||
| #include "configfile.h" | |||
There was a problem hiding this comment.
I wish we don't make dependency between the sync engine and the config file.
There was a problem hiding this comment.
Since if it's for a debugging purpose, maybe an environment variable would work. But I think we could also leave it out. Who is this debug option for? Developers can as well comment the code that does the checking.
|
I did not see the validateChecksumOnDownload Should we really get rid of the branding option? branding who enables this option do it because their server is capable? Or is it assumed that the branding would also have their own server? |
|
@ogoffart yes, there is only one branding using that. And they agreed on setting the server capability. |
|
Didn't we agree that this option is not needed? And to use capabilities and not the configuration file? |
|
Yes, we did, I guess that is exactly what Christian means. |
Added in previous commit from pull request #4663 As discussed, we do not need this option so no need to introduce a new dependency on the config file in the sync engine
Disable validation of transmission checksums by default
The server may send invalid checksums when files change on disk,
see owncloud/core#23783.
Introduces a new validateChecksumOnDownload configuration and
branding option.