Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump sshpk from 1.13.1 to 1.15.2 in /build #33753

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 4, 2018

Bumps sshpk from 1.13.1 to 1.15.2. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Sonatype OSS Index.

CWE-400: Uncontrolled Resource Consumption ('Resource Exhaustion')
The software does not properly restrict the size or amount of resources that are requested or influenced by an actor, which can be used to consume more resources than intended.

Affected versions: <1.14.1

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects sshpk
The sshpk NPM package is vulnerable to ReDoS when parsing crafted invalid public keys.

Affected versions: < 1.13.2

Sourced from The Node Security Working Group.

Denial of Service
sshpk is vulnerable to ReDoS when parsing crafted invalid public keys

Affected versions: <=1.13.1

Release notes

Sourced from sshpk's releases.

v1.14.1

  • Remove all remaining usage of jodid25519 (abandoned dep)
  • Add support for DNSSEC key format
  • Add support for Ed25519 keys in PEM format (according to draft-curdle-pkix)
  • Fixes for X.509 encoding issues (asn.1 NULLs in RSA certs, cert string type mangling)
  • Performance issues parsing long SSH public keys
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

@dependabot-bot rebase

Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.15.2. **This update includes security fixes.**
- [Release notes](https://github.com/joyent/node-sshpk/releases)
- [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.15.2)

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/sshpk-1.15.2 branch from 726041c to 6a76c8a Compare December 18, 2018 15:00
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #33753 into stable10 will decrease coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #33753      +/-   ##
==============================================
- Coverage       63.56%   62.79%   -0.77%     
+ Complexity      19102    19006      -96     
==============================================
  Files            1264     1248      -16     
  Lines           75110    74538     -572     
  Branches         1286     1286              
==============================================
- Hits            47744    46807     -937     
- Misses          26986    27351     +365     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.19% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.83% <ø> (-0.85%) 19006 <ø> (-96)
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/ActivityHelper.php 0% <0%> (-100%) 8% <0%> (ø)
apps/comments/lib/Activity/Listener.php 25.58% <0%> (-69.77%) 11% <0%> (ø)
apps/systemtags/lib/Activity/Listener.php 0% <0%> (-62.89%) 29% <0%> (-3%)
lib/public/SystemTag/MapperEvent.php 38.46% <0%> (-61.54%) 5% <0%> (ø)
apps/files_external/lib/Lib/Storage/SMB.php 0% <0%> (-47.73%) 0% <0%> (ø)
lib/public/AppFramework/App.php 63.63% <0%> (-18.19%) 5% <0%> (ø)
apps/systemtags/lib/Activity/Extension.php 0% <0%> (-15%) 46% <0%> (-1%)
lib/private/Files/Meta/MetaVersionCollection.php 80.48% <0%> (-7.02%) 16% <0%> (ø)
lib/private/Share/Share.php 67.03% <0%> (-4.07%) 502% <0%> (ø)
lib/public/Share.php 61.81% <0%> (-3.64%) 26% <0%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1575b28...6a76c8a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #33753 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #33753   +/-   ##
===========================================
  Coverage       63.56%   63.56%           
  Complexity      19102    19102           
===========================================
  Files            1264     1264           
  Lines           75110    75110           
  Branches         1286     1286           
===========================================
  Hits            47744    47744           
  Misses          26986    26986           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.19% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <ø> (ø) 19102 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/response.php 21.42% <0%> (ø) 50% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1575b28...6a76c8a. Read the comment docs.

@dependabot-preview
Copy link
Contributor Author

Superseded by #33966.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/build/stable10/sshpk-1.15.2 branch December 24, 2018 22:13
@lock lock bot locked as resolved and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants