fix: proofkeys validation with proxy #10462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbar
requested review from
wkloucek,
phil-davis and
individual-it
as code owners
micbar
force-pushed
the
fix-proofkeys-o365
branch
2 times, most recently
from
a033dc4 to
f9510e0
Compare
|
Unfortunately the ProofKeys TestSuite is not functional. While digging into the upstream repo, i found this microsoft/wopi-validator-core#22 (comment) which means the upstream status of the WOPI Validator is unclear. @ScharfViktor that means we need an E2E test with Collabora and proofkeys enabled. |
|
|
Maybe I am not recalling it properly, but aren't we running our wopi validator from a fork? |
|
No. I was wrong... Nevertheless we could fork it ..... 🤷 |
jvillafanez
approved these changes
Nov 5, 2024
ownclouders
pushed a commit
that referenced
this pull request
Nov 5, 2024
fix: proofkeys validation with proxy
This was referenced Dec 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: Respect proxy url when validating proofkeys
We fixed a bug where the proxied wopi URL was not used when validating proofkeys. This caused the validation to fail when the proxy was used.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: