Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid type in ocis_traefik docker-compose file #5628

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix invalid type in ocis_traefik docker-compose file #5628

merged 1 commit into from
Feb 22, 2023

Conversation

ChrisEdS
Copy link
Contributor

Description

Fix for
ERROR: The Compose file './docker-compose.yml' is invalid because: services.ocis.environment.NOTIFICATIONS_SMTP_INSECURE contains true, which is an invalid type, it should be a string, number, or a null

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ChrisEdS ChrisEdS added the Status:Needs-Review Needs review from a maintainer label Feb 22, 2023
@ChrisEdS ChrisEdS requested a review from wkloucek February 22, 2023 14:35
@ChrisEdS ChrisEdS self-assigned this Feb 22, 2023
@update-docs
Copy link

update-docs bot commented Feb 22, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek merged commit 4591c7e into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the ChrisEdS-docker-compose-fix branch February 22, 2023 18:04
ownclouders pushed a commit that referenced this pull request Feb 22, 2023
@wkloucek
commit 4591c7e
c01f6fd 
Merge: 7fd3faf 6e1dc16
Author: Willy Kloucek <[email protected]>
Date:   Wed Feb 22 19:04:05 2023 +0100

    Merge pull request #5628 from owncloud/ChrisEdS-docker-compose-fix

    Fix invalid type in ocis_traefik docker-compose file
ownclouders pushed a commit that referenced this pull request Feb 23, 2023
@wkloucek
commit 4591c7e
274e5c9 
Merge: 7fd3faf 6e1dc16
Author: Willy Kloucek <[email protected]>
Date:   Wed Feb 22 19:04:05 2023 +0100

    Merge pull request #5628 from owncloud/ChrisEdS-docker-compose-fix

    Fix invalid type in ocis_traefik docker-compose file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees

@ChrisEdS ChrisEdS

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisEdS @wkloucek