Fix Windows DNS issues #2076
Merged
Fix Windows DNS issues #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DNS resolver code should not and can not be responsible for preventing packet looping.
We simply keep the WINDIVERT_ADDRESS struct given on recv, so when using it for send we need to invert the direction (the Output bit)
majestrate
reviewed
Nov 22, 2022
majestrate
reviewed
Nov 22, 2022
majestrate
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of bugs with Windows DNS handling:
OS DNS config matching lokinet upstream config will work now
Windivert
WINDIVERT_ADDRESS.Outboundflag will now be set correctly, i.e. packet injection will be in the correct direction.These two points together should fix #2073
Also adds a bunch of debug logging