Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustdoc on translating 'number' into 'rust_decimal:Decimal' #761

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

kairsas
Copy link
Contributor

@kairsas kairsas commented Jan 31, 2025

I just spent some time figuring this out myself and thought maybe it might be useful to someone else.

@kairsas kairsas marked this pull request as ready for review January 31, 2025 09:18
Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change for your consideration. Thanks so much for contributing this!

/// instance_type: Some(InstanceType::Number.into()),
/// ..Default::default()
/// },
/// "rust_decimal::Decimal",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// "rust_decimal::Decimal",
/// "::rust_decimal::Decimal",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed it.

@ahl ahl merged commit 82868f8 into oxidecomputer:main Feb 3, 2025
4 checks passed
@kairsas kairsas deleted the rust-decimal-example branch February 9, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants