Silence 7zip when unpacking #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jul 30, 2021
oxinabox
reviewed
Jul 30, 2021
test/post_fetch_helpers.jl
Outdated
| end | ||
|
|
||
| @testset "sad case" begin | ||
| @test_throws Exception unpack("assets/non-existent.zip") |
There was a problem hiding this comment.
I think this is spelt wrong but:
Suggested change
| @test_throws Exception unpack("assets/non-existent.zip") | |
| # depending on Julia version maybe ErrorException or ProcessExittedExcept | |
| @test_throws Union{ErrorException,ProcessExittedException} unpack("assets/non-existent.zip") |
oxinabox
reviewed
Jul 30, 2021
Comment on lines
+6
to
+15
| std = stdout | ||
| r, w = redirect_stdout() | ||
| try | ||
| f() | ||
| finally | ||
| redirect_stdout(std) | ||
| close(w) | ||
| end | ||
| output = read(r, String) | ||
| return output |
There was a problem hiding this comment.
Can't we do: const capture_stdout = sprint ∘ redirect_stdout ?
There was a problem hiding this comment.
interesting, let me look into that (copy pasting this results in an error, but may be workable)
There was a problem hiding this comment.
I still think there must be a much shorter way to do this.
Did you get a chance to look at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142