Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registering same DataDep twice a no-op #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make registering same DataDep twice a no-op #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/registration.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ const registry = Dict{String, AbstractDataDep}()
function register(datadep::AbstractDataDep)
name = datadep.name
if haskey(registry, name)
if isequal(datadep, registry[name])
return registry
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return registry
return registry[name]

Might be a cleaner way to do this, using say:

existing = get(regisitry, name, nothing)
if existing != nothing
     if isequal(datadep, existing)
          return existing
    else
          @warning...
     end
end

or something like that?

end
@warn("Over-writing registration of the datadep", name)
end
if !is_valid_name(name)
Expand Down