Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if target is little-endian on arm64 and wasm32 #11

Merged
merged 1 commit into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "sbbf-rs"
version = "0.2.7"
version = "0.2.8"
edition = "2021"
license = "MIT"
description = "Split block bloom filter implementation"
Expand Down
16 changes: 8 additions & 8 deletions src/arch/mod.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#[cfg(target_arch = "aarch64")]
#[cfg(all(target_arch = "aarch64", target_endian = "little"))]
mod aarch64;
mod fallback;
#[cfg(all(target_family = "wasm", target_feature = "simd128"))]
#[cfg(all(target_family = "wasm", target_feature = "simd128", target_endian = "little"))]
mod wasm;
#[cfg(any(target_arch = "x86_64", target_arch = "x86"))]
mod x86;
Expand All @@ -20,21 +20,21 @@ pub(crate) fn load() -> &'static dyn crate::FilterImpl {
}
}

#[cfg(target_arch = "aarch64")]
#[cfg(all(target_arch = "aarch64", target_endian = "little"))]
pub(crate) fn load() -> &'static dyn crate::FilterImpl {
&aarch64::NeonFilter
}

#[cfg(all(target_family = "wasm", target_feature = "simd128"))]
#[cfg(all(target_family = "wasm", target_feature = "simd128", target_endian = "little"))]
pub(crate) fn load() -> &'static dyn crate::FilterImpl {
&wasm::WasmFilter
}

#[cfg(not(any(
target_arch = "x86_64",
target_arch = "x86",
target_arch = "aarch64",
all(target_family = "wasm", target_feature = "simd128")
all(target_arch = "aarch64", target_endian = "little"),
all(target_family = "wasm", target_feature = "simd128", target_endian = "little")
)))]
pub(crate) fn load() -> &'static dyn crate::FilterImpl {
&fallback::FallbackFilter
Expand All @@ -43,8 +43,8 @@ pub(crate) fn load() -> &'static dyn crate::FilterImpl {
#[cfg(any(
target_arch = "x86_64",
target_arch = "x86",
target_arch = "aarch64",
all(target_family = "wasm", target_feature = "simd128")
all(target_arch = "aarch64", target_endian = "little"),
all(target_family = "wasm", target_feature = "simd128", target_endian = "little")
))]
const SALT: [u32; 8] = [
0x47b6137b, 0x44974d91, 0x8824ad5b, 0xa2b7289d, 0x705495c7, 0x2df1424b, 0x9efc4947, 0x5c6bfb31,
Expand Down
Loading