Skip to content

Commit

Permalink
Accept unique suffixes as valid identifiers in CLI
Browse files Browse the repository at this point in the history
A recent change in p4lang/p4c added the missing top-level control name
to the fully-qualified name of objects defined within this control. The
fully-qualified is what appears in the bmv2 JSON and what is expected by
the Thrift server. To avoid breaking exsiting examples / tutorials which
use the bmv2 runtime_CLI to install table entries, we now accept unique
suffixes of the fully-qualified name as valid indentifiers in the
runtime_CLI.

New code should probably transition to the correct fully-qualified name
instead of relying on this feature. Which is why auto-completion does
not suggest suffixes.
  • Loading branch information
antoninbas committed Mar 14, 2018
1 parent f6f5de7 commit 5455c63
Showing 1 changed file with 139 additions and 85 deletions.
Loading

0 comments on commit 5455c63

Please sign in to comment.